Feature/merge zf1 future master #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Count issue fix
PHP 7.3: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"?
just another case of the same warning
fix(Form.php): PHP7.3 warning
ZF1 dependencies (i.e. zf1 doctrine) require the original zf1 package. This PR adds `replace` to composer.json to make sure regular zf1 is not included in the vendor.
Add replace in composer.json for zf1 dependencies
Patch Reflection File: replace continue by break in switch context
…ze and Zend_Validate_File_ImageSize.
Fixed return value for isValid() method in Zend_Validate_File_FilesSi…
Break from switch-case to retry redirected URI regarding deletion.
Update Atom.php
…olumn-adsrc Replace d.adsrc that it's removed into postgresql 12 zendframework#28
Bump version to 1.15.2
Fix php 7.4 deprecation curly brakets access on strings
…d php versions as we move to support php 7.4
… object deprecation warning The method offsetExists was a workaround for a SPL bug which was fixed in April 2007, see http://bugs.php.net/bug.php?id=40442
…-object-in-registry-php Remove offsetExists from Zend_Registry to silence deprecation warning
feat: pdo_sqlsrv by Akrabat
…brakets-on-string Replace curly brakets for PHP 7.4 compatibility
(PHP 5, PHP 7)
iconv_substr — Cut out part of a string
Description
iconv_substr ( string $str , int $offset [, int $length = iconv_strlen($str, $charset) [, string $charset = ini_get("iconv.internal_encoding") ]] ) : string
...
Version Description
7.0.11 If str is equal to offset characters long, an empty string will be returned. Prior to this version, FALSE was returned in this case.
Because of the above change, ZF1 fails to successfully initialise a DateTime object when necessary information is missing from the value provided leading to unhandled exception.
Address iconv_substr incompatibility between php 5.x and 7.x
…ature/merge-zf1-future-master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With zf1 EOF, we still need to migrate Bob to PHP 7.4 ++. Because of this, we are merging all changes from zf1-future into our current master. Here is the discussion regards that.
https://github.com/theiconic/bob/pull/3071
Also, Fab and Aaron have reviews all PRs which you can find the reference here.
https://docs.google.com/spreadsheets/d/1QhKwPjZj__x8VjKtn35XHsK7g2ahHBekce-qKkMU9fo/edit?usp=sharing